Thanks Dmitri for the review and the +1, and thanks Yufei for the suggestion. I 
agree that allowing two expire-at properties adds unnecessary complexity. I'll 
update the PR to throw when more than one expiration timestamp is present. This 
would keep the contract simple (as originally intended I'm assuming): one 
credential bundle <> one expiration.

Best,
Prathyush

> On Apr 15, 2026, at 5:18 PM, Dmitri Bourlatchkov <[email protected]> wrote:
> 
> Hi All,
> 
> PR [4173] adds extra validation to ConnectionCredentials to avoid ambiguity
> WRT expiration timestamps.
> 
> I believe this is a solid fix worth merging.
> 
> However, there is a potential for breakage in environments that previously
> had incorrect configuration.
> 
> All in all, the PR has been in review for 3 days. I propose merging
> tomorrow.
> 
> [4173] https://github.com/apache/polaris/pull/4173
> 
> Cheers,
> Dmitri.

Reply via email to