Hi, I strongly agree that we should not induce new build warnings and ensure code quality. PR owners must check it before opening a PR.
Regarding the discussion about deprecation, There may be downstream projects that are still using these public interfaces. So, IMO we still need to mark code as deprecated. Just mentioning it in the doc may not be enough as not everyone will read the docs always. Regarding replacing Deprecated usage in code, I agree that we should do it whenever we deprecate to avoid inducing compile warnings. We can also follow Iceberg's semantic versioning here for deprecation. So, the user will know in which version it will be removed by checking javadocs. https://iceberg.apache.org/contribute/?h=minor#semantic-versioning - Ajantha On Fri, Jul 10, 2026 at 6:58 AM Dmitri Bourlatchkov <[email protected]> wrote: > Hi All, > > This is to follow-up on review comments in PR [5012], specifically [1] > > People working with the codebase on a regular basic have to pay attention > to many factors to ensure code quality. This requires a significant > cognitive effort. > > One of the factors is the presence of build warnings. I believe it is a > generally good practice to avoid introducing new build warnings when > technically possible. > > Thoughts? > > [1] https://github.com/apache/polaris/pull/5012#discussion_r3547988353 > > [5012] https://github.com/apache/polaris/pull/5012 > > Thanks, > Dmitri. >
