Hi All, This came to the forefront during the review of PR [5520].
PolarisMetaStoreManager declares the hasOverlappingSiblings() method. Currently, all persistent implementations of this method search all entities within the catalog. However, the caller of this method, LocalIcebergCatalog.validateNoLocationOverlap(), invokes it only when the OPTIMIZED_SIBLING_CHECK flag is set. If the flag is _not_ set, LocalIcebergCatalog searches only among immediate siblings. I think this is a logical inconsistency. An "optimization" should not alter the validation method's basic behaviour. I'd like to propose adjusting hasOverlappingSiblings() implementations to _only_ search among true siblings. WDYT? [5520] https://github.com/apache/polaris/pull/5520 Thanks, Dmitri.
