Hi all,

Dmitri asked me to bring PR #5909 [1] to the list because it changes the
HTTP status code of two
Management API error responses.

Today, creating an EXTERNAL catalog with an invalid connectionConfigInfo
fails with
500 Internal Server Error in two cases, although both are client input
errors:

1. a connectionType or authenticationType that is not in
SUPPORTED_CATALOG_CONNECTION_TYPES /
   SUPPORTED_EXTERNAL_CATALOG_AUTHENTICATION_TYPES (an
IllegalStateException escapes), and
2. a request without authenticationParameters (a NullPointerException
escapes; the spec only
   marks connectionType as required).

The PR makes both return 400 Bad Request. The messages for case 1 are
unchanged; case 2 gets
"authenticationParameters is required for an external catalog". The spec
description of
ConnectionConfigInfo now states that authenticationParameters is required.
Valid requests are
unaffected, and nothing else in the error handling changes. Issue: #5908
[2].

The PR has one approval (Dmitri). If nobody objects within a few days I
would ask for it to be
merged as is; happy to adjust if there are concerns about the code or the
message.

[1] https://github.com/apache/polaris/pull/5909
[2] https://github.com/apache/polaris/issues/5908

Best regards,
Youngrae Kim

Reply via email to