Hi all,

> do we want to hold this until we branch 1.9.0?

I think we should do the opposite: otherwise, cherry-picking from main
into the release branch could incur in frequent formatting issues.
WDYT?

Thanks,
Alex

On Mon, Nov 9, 2026 at 3:36 PM Dmitri Bourlatchkov via dev
<[email protected]> wrote:
>
> Hi All,
>
> +1 to google format v2 and full reformat in one go.
>
> Practically speaking, do we want to hold this until we branch 1.9.0?
>
> Thanks,
> Dmitri.
>
> On Mon, Nov 9, 2026 at 2:19 AM Jean-Baptiste Onofré <[email protected]> wrote:
>
> > Hi Yong,
> >
> > +1 to move to google-java-format V2.
> >
> > As I said in PR #5973, 1.37.0 doesn't work with our current Spotless
> > version. v2 also gives more compact code, so I think it's better to do the
> > full reformat once now.
> >
> > I suggest we give 72 hours for any concern, then we can merge #6010
> > quickly to reduce the risk of conflicts (also it gives time for
> > contributors to update google-java-format in their IDE).
> >
> > For existing PRs, we will have to:
> > - rebase
> > - apply ./gradlew spotlessApply and commit
> >
> > I will review the PR, thanks!
> >
> > Regards
> > JB
> >
> > On Mon, Nov 9, 2026 at 7:50 AM Yong Zheng via dev <[email protected]>
> > wrote:
> >
> > > Hello team,
> > >
> > > We are planning to update dependency
> > > com.google.googlejavaformat:google-java-format to v2. This is discussed
> > > between JB and Yufei via https://github.com/apache/polaris/pull/5973.
> > >
> > > Here is the current PR for this change:
> > > https://github.com/apache/polaris/pull/6010
> > >
> > > As this PR reformat the code with google-java-format v2, it will likely
> > > caused conflicts on many existed PRs.
> > >
> > > Let us know if any concern before we merge the PR.
> > >
> >

Reply via email to