Hi, PR [6035] (merged) adds an optional stsEndpoint to SigV4 connection authentication. Its validation currently lives in PolarisServiceImpl.validateExternalCatalog, which runs only on the REST create path.
Thanks to Dmitri for suggesting we look at CatalogConfigValidator for this, I think CatalogConfigValidator can act as a possible home for this validation, and maybe it applies to federated catalogs too: - The interface receives the full Catalog model, including ExternalCatalog's connection and storage configs. BigLakeCatalogValidator already validates federated catalogs this way. - PolarisAdminService calls CatalogConfigValidators.validate on both create and update. For the follow-up in [6051] (validating storage configuration stsEndpoint), I'd like to implement the checks as a CatalogConfigValidator so that they run on create and update through the same path. Design question: the interface does not distinguish create from update. The update path passes the full entity, including the connection config, so a SigV4 check in a validator would also run on every update of an existing federated catalog. If ALLOW_SETTING_S3_ENDPOINTS is later set to false, existing catalogs with an stsEndpoint would fail on update, even though the connection config is create-only. Should we: 1. add create/update context to CatalogConfigValidator, 2. keep the connection check on the create-only path, or 3. accept that updates are validated too and document it? [6051]: https://github.com/apache/polaris/issues/6051 [6035]: https://github.com/apache/polaris/pull/6035 Thanks, Arnab
