Except!!!! It is not that... It is something else... On Wed, Jun 7, 2017 at 3:40 PM, Niclas Hedhman <[email protected]> wrote:
> Oh... some more; > > PropertyMapper > CompositeAssemblyImpl > > > > > On Wed, Jun 7, 2017 at 3:38 PM, Niclas Hedhman <[email protected]> wrote: > >> I find it in the following places (note to myself where to fix it later); >> >> TransientClassLoader ( 2 places ) >> FragmentClassLoader ( 2 places ) >> ConstructorsModel (2 places) >> CompositeModel >> CompositeMethodModel >> >> I also suspect that the "check for public" in AccessibleObjects helper >> should just not be done. >> >> >> Since this is happening during startup, I suspect that you had other >> reason than performance to make this change. Would like to hear about it. >> >> >> Cheers >> >> >> >> On Wed, Jun 7, 2017 at 3:31 PM, Niclas Hedhman <[email protected]> >> wrote: >> >>> >>> So Paul, in commit 40d8d6de0c4c459d09ffad31110b3057d175536a you removed >>> setAccessible(true) in CompositeMethodModel, on the basis that it is not >>> needed. After all, the method is from an interface and public by default. >>> >>> But that is for some reason not true. >>> >>> https://drive.google.com/open?id=0B1oCChgcqYT7RVhvMG1oaHBJQXc >>> https://drive.google.com/open?id=0B1oCChgcqYT7YlRDZnRXc2VBcnc >>> >>> >>> and for completeness >>> >>> public interface SqlTable >>> { >>> BaseEntity fetchBaseEntity( EntityReference reference, ModuleDescriptor >>> module ); >>> >>> >>> >>> So, I have no idea why a public interface method is not "accessible", >>> perhaps it is something new, or something leaking from Java 9. >>> >>> I am also very concerned that our tests don't catch this. I will try to >>> reproduce this for test setting prior to adding the "set accessible" to the >>> above place. Additionally, were there any other locations where this was >>> changed? >>> >>> >>> >>> Cheers >>> >>> On Wed, Jun 7, 2017 at 3:01 PM, Niclas Hedhman <[email protected]> >>> wrote: >>> >>>> >>>> Uhhh.... I have just found this particularly interesting situation; >>>> >>>> https://drive.google.com/file/d/0B1oCChgcqYT7a2N5RktQNWlSQnM/view >>>> https://drive.google.com/open?id=0B1oCChgcqYT7aEJSeW9NdFUwaWM >>>> >>>> >>>> The method has "public" modifiers (it is public in the code), but the >>>> "isAccessible()" is reporting false. >>>> >>>> Anybody has any ideas on how this is possible? Is there anywhere we >>>> change "accessible" to false? >>>> >>>> Cheers >>>> -- >>>> Niclas Hedhman, Software Developer >>>> http://polygene.apache.org - New Energy for Java >>>> >>> >>> >>> >>> -- >>> Niclas Hedhman, Software Developer >>> http://polygene.apache.org - New Energy for Java >>> >> >> >> >> -- >> Niclas Hedhman, Software Developer >> http://polygene.apache.org - New Energy for Java >> > > > > -- > Niclas Hedhman, Software Developer > http://polygene.apache.org - New Energy for Java > -- Niclas Hedhman, Software Developer http://polygene.apache.org - New Energy for Java
