I think I have fixed the ignore_body issue -- the setting is now passed to the Archiver. However there are as yet no tests.
Do you have any mbox files that are suitable? On Sat, 22 Aug 2020 at 09:38, Daniel Gruno <[email protected]> wrote: > > On 21/08/2020 23.18, sebb wrote: > > Since archiver.py was revamped in > > 95beb51158b58bcb9fdb1371af7699b72598ac34, import-mbox.py can no longer > > pass the ignore_body setting to archiver.py > > > > This is because the top-level iBody variable in archiver.py no longer > > exists. > > > > I think the communication between import-mbox and archiver needs a rethink. > > > > AFAICT all the configuration settings are fixed for the life of the > > script, so it does not make much sense for them to be passed to > > Archiver class methods such as compute_updates. > > > > It seems to me that all the settings should all be passed across when > > creating the Archiver, and no args passed directly to class methods. > > > > Agreed? > > > > Agreed - anything that gets passed to the archiver would be the same > arguments over and over, so it makes sense to just set it once during > class init.
