On Wed, 26 Aug 2020 at 12:02, Daniel Gruno <[email protected]> wrote: > > On 26/08/2020 12.55, sebb wrote: > > Why is Python 3.8+ required > > > The code seems to work OK for me using 3.7.8. > > I think the thought was that while setup.py will work, the backend won't > work with <3.8 because of the use of async features. I'll have to check. > It will probably be better to just have a warning than an exit(-1) > there, as the backend can often be found on a different system than the > setup program.
The Python requirements need to be documented (in the README). > > > > On Tue, 25 Aug 2020 at 21:28, <[email protected]> wrote: > >> > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> humbedooh pushed a commit to branch master > >> in repository > >> https://gitbox.apache.org/repos/asf/incubator-ponymail-foal.git > >> > >> > >> The following commit(s) were added to refs/heads/master by this push: > >> new a10bc4e check this first > >> a10bc4e is described below > >> > >> commit a10bc4eb9b08e935f42abea2390538f2dff55b18 > >> Author: Daniel Gruno <[email protected]> > >> AuthorDate: Tue Aug 25 22:28:22 2020 +0200 > >> > >> check this first > >> --- > >> tools/setup.py | 9 +++++---- > >> 1 file changed, 5 insertions(+), 4 deletions(-) > >> > >> diff --git a/tools/setup.py b/tools/setup.py > >> index 700a644..4798ff4 100755 > >> --- a/tools/setup.py > >> +++ b/tools/setup.py > >> @@ -23,6 +23,11 @@ import sys > >> import yaml > >> > >> > >> +if sys.version_info <= (3, 7): > >> + print("This script requires Python 3.8 or higher") > >> + sys.exit(-1) > >> + > >> + > >> hostname = "" > >> port = 0 > >> dbname = "" > >> @@ -64,10 +69,6 @@ def create_indices(): > >> print(f"Index {dbname}-{index} created! %s " % res) > >> > >> > >> -if sys.version_info <= (3, 7): > >> - print("This script requires Python 3.8 or higher") > >> - sys.exit(-1) > >> - > >> # Check for all required python packages > >> wanted_pkgs = [ > >> "elasticsearch", # used by setup.py, archiver.py and elastic.py > >> >
