On Wed, 2 Jun 2021 at 18:32, Daniel Gruno <[email protected]> wrote: > > I've made it so that the tests will pass with 56 specific format=flowed > issues in mind.
Wrong, so wrong. > We have the option of: > - Be strict and let foal fail forever > - Be flexible and have foal and pony differ in these specific cases > - Create a separate set of tests for both Or, fix foal so it generates the same results for the same generators. I realise that foal has deprecated the old generators, however it still offers them as options. There is no point in doing so if the results are different, which is why the tests were set up. Fixing the tests does not make the code correct, it just hides the problems. We have to make allowances for v 0.10, because incompatible changes were made previously. It's not possible to change the past, so we have to live with it. However, for new code, it is possible to get it right -- or at least not make it more wrong. > I am leaning towards option 2, which is how it is right now. Option 1 > means we can't use the tests for foal, and option 3 would mean we risk > not noticing when the two diverge. > > For the places where the tests diverge (and need alternates), I've put a > top comment in each YAML specifying who/why. I think this is currently > the best compromise. There is no need to compromise. Foal needs to generate the same output for the same input for all the historic generators that it supports. Anything else just makes an already bad situation worse. >
