sbp commented on pull request #43:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/43#issuecomment-859439603
> I'm concerned that the code adds a couple of searches to the archiver,
which is the most critical part of the system.
Another possibility is that the properties added by this code could be added
to a new separate table, e.g. `{dbname}_threads`. To avoid impacting archiver
performance the code could even be added in a separate archiver module, with
its own archiver hook in Mailman3 or separate stdin workflow. But note that the
code is entirely optional, and has to be configured to be enabled. By default
the code is not enabled.
As for a mapping from `message-id` to database ID, elastic can already make
such queries on the existing code. Indeed this query is already done in the
code in this PR, in the `get_by_message_id` function in `archiver.py`. It's not
clear why a table for this would be a good substitute for any of the other work
that the code in this PR does, for example in parsing `in-reply-to` and
`references` headers, nor even whether it would optimise `get_by_message_id`
very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
