sbp commented on issue #49: URL: https://github.com/apache/incubator-ponymail-foal/issues/49#issuecomment-890335304
A couple of problems with this: 1. The new module has to replicate much of the computation in the original archiver module, including generating the whole `ojson`object. 2. It's no longer possible to include the thread data in the `dumponfail` output. The first issue isn't too bad if the computation isn't too intensive, and the method can just be imported from the archiver module and reused, guaranteeing that it works in the same way. But the second issue cannot be ignored. One possible alternative is to use a [timeout decorator](https://pypi.org/project/timeout-decorator/), which would only be imported and used if thread capabilities are enabled. The whole code region could also be wrapped in a try/except block in case of errors. That way a maximum execution duration would be guaranteed, and errors should be prevented from affecting the rest of the archiver code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
