sebbASF commented on a change in pull request #58:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/58#discussion_r711614226
##########
File path: tools/archiver.py
##########
@@ -920,6 +935,11 @@ def main():
help="If pushing to ElasticSearch fails, dump documents in JSON format
to this directory and "
"fail silently.",
)
+ parser.add_argument(
+ "--defaultdate",
Review comment:
Given that the value is treated as an epoch, why no call it defaultepoch?
There might be a use-case for the defaulting to the current time: that is no
longer possible.
Given that epoch cannot be negative, maybe use -1 for skip and -2 for
current time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
