sebbASF commented on code in PR #246:
URL:
https://github.com/apache/incubator-ponymail-foal/pull/246#discussion_r1150542845
##########
tools/archiver.py:
##########
@@ -211,6 +211,11 @@ def __init__(self, part: email.message.Message):
break
except UnicodeDecodeError:
pass
+ except:
Review Comment:
At this point in the logic, the only thing that can legitimately fail is the
string.decode(), so that is all that should be permitted. For example,
IndexError should not occur here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
