grobmeier commented on code in PR #261:
URL: 
https://github.com/apache/incubator-ponymail-foal/pull/261#discussion_r1667767177


##########
.gitignore:
##########
@@ -142,3 +142,4 @@ dmypy.json
 # Pipenv files
 Pipfile
 Pipfile.lock
+/elastic

Review Comment:
   I have removed it to unblock this PR. 
   
   However, I still don't get why this change is not OK. Why would I remove the 
/elastic directory when I want to work with it? Isn't .gitignore for preventing 
exactly those working dirs from being committed? I haven't seen any other 
.gitignore files and the elastic/logs still show up as uncommitted changes in 
my Git. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to