Thanks for catching that Naoki! I have commented in your PR: https://github.com/apache/predictionio-sdk-java/pull/7
I will do an RC2 once that is merged. Cancelling this vote thread. On Wed, Sep 12, 2018 at 2:36 AM Naoki Takezoe <[email protected]> wrote: > Sorry, RAT errors were my mistake. IntelliJ specific files were > included. After removing them, "mvn clean install" worked. > However examples don't work without modification. > > 2018年9月12日(水) 17:43 Naoki Takezoe <[email protected]>: > > > > Hi Donald, > > > > Thanks for your work! > > > > However it seems to have several problems in README and examples. I > > tried examples following to the instruction in README, but I couldn't > > do anything. For example, I got a following error when I tried to "mvn > > clean install" at the root of the source tree following to README: > > > > [ERROR] Failed to execute goal > > org.apache.rat:apache-rat-plugin:0.12:check (validate) on project > > predictionio-sdk-java: Too many files with unapproved license: 10 See > > RAT report in: /Users/takezoe/predictionio-sdk-java/target/rat.txt -> > > [Help 1] > > > > Further, the dependency to java-sdk in examples is now as below: > > > > <dependency> > > <groupId>org.apache.predictionio</groupId> > > <artifactId>client</artifactId> > > <version>0.13.0</version> > > </dependency> > > > > But I guess correct one is below: > > > > <dependency> > > <groupId>org.apache.predictionio</groupId> > > <artifactId>predictionio-sdk-java-client</artifactId> > > <version>0.13.0</version> > > </dependency> > > > > Since they aren't published Java SDK's problems, so we might be able > > to release as it is and fix README and examples later. But in my > > opinion, the release includes a source archive and the repository will > > be tagged as a version. All of them need to be consistent at the > > release point. > > > > Now I'm preparing a pull request to fix these problems. I believe we > > need to include it in 0.13.0 release of Java SDK. > > > > So here is my -1. > > > > Regards, > > > > 2018年9月12日(水) 3:49 Donald Szeto <[email protected]>: > > > > > > This is the vote for 0.13.0 of Apache PredictionIO Java SDK. This is a > > > Maven-only release. > > > > > > The vote will run for at least 72 hours and will close on Sep 14th, > 2018. > > > > > > The release candidate artifacts can be downloaded here: > > > > https://repository.apache.org/content/repositories/orgapachepredictionio-1023/ > > > > > > Test results of RC1 can be found here: > > > https://travis-ci.org/apache/predictionio-sdk-java/builds/427335800 > > > > > > All JIRAs completed for this release are tagged with 'FixVersion = > 0.13.0 > > > (Java SDK)'. > > > You can view them here: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320420&version=12344073 > > > > > > The artifacts have been signed with Key: 8BF4ABEB > > > > > > Please vote accordingly: > > > > > > [ ] +1, accept RC as the official 0.13.0 Java SDK release > > > [ ] -1, do not accept RC as the official 0.13.0 Java SDK release > because... > > > > > > > > -- > > Naoki Takezoe > > > > -- > Naoki Takezoe >
