I’m always disinclined to commit code that has not been tested. However many 
things in the current state of the develop branch seem broken or at least too 
big to address in a single commit.

1) Style test fail in Travis that are not runnable or at least have not been 
documented for local build. I have fixed these.
2) SSL seems to still be required for deploying an engine, PIO-1 may not have 
addressed this. Has anyone tried to build and test a template yet without SSL? 
Unless someone can state otherwise I’m inclined to ignore this failure for now 
since it is out of scope for this commit.
3) the test framework has been integrated into Travis but again no documented 
way to run it locally and some of the travis errors seem spurious. I am also 
not inclined to wait for this to be fixed unless someone can point out real 
problems it is discovering and send instructions for how to run it locally.

Before the extra travis tests I was able to build and train a template, which 
fails on deploy with an SSL config error. Since the PR does not strictly touch 
any templates I am going to have to ignore this serious issue and address it in 
Jira.

Unless someone vetos this I plan to reluctantly push the PR with these 
non-trivial issues remaining.


Reply via email to