[
https://issues.apache.org/jira/browse/PIO-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478398#comment-15478398
]
ASF GitHub Bot commented on PIO-34:
-----------------------------------
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/292
Thanks for your contribution @bansarishah ! Most of it looks great to me. A
few suggested improvement:
* highlight the need to change `appId` in `engine.json`
* or even better, use the `PEventStore` API so that it relies on the app
name rather than ID
I will hold this until the Apache release is out. PredictionIO 0.10.0 has
reached RC status. Once the final release is published, we will accept this PR
after the engine template is modified to use the final released artifact.
> Integrate BagOfWords Sentiment analysis template with PredictionIO
> -------------------------------------------------------------------
>
> Key: PIO-34
> URL: https://issues.apache.org/jira/browse/PIO-34
> Project: PredictionIO
> Issue Type: New Feature
> Affects Versions: future release
> Reporter: Bansari Shah
>
> For integrating a new sentiment analysis template that follows Bag of words
> model, build with predictionIO-0.9.7-SNAPSHOT, scala - 2.10.6 and spark 1.5.1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
