Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/292
  
    Thanks for your contribution @bansarishah ! Most of it looks great to me. A 
few suggested improvement:
    
    * highlight the need to change `appId` in `engine.json`
    * or even better, use the `PEventStore` API so that it relies on the app 
name rather than ID
    
    I will hold this until the Apache release is out. PredictionIO 0.10.0 has 
reached RC status. Once the final release is published, we will accept this PR 
after the engine template is modified to use the final released artifact.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to