[ 
https://issues.apache.org/jira/browse/PIO-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524988#comment-15524988
 ] 

ASF GitHub Bot commented on PIO-35:
-----------------------------------

Github user dszeto commented on a diff in the pull request:

    
https://github.com/apache/incubator-predictionio/pull/300#discussion_r80616820
  
    --- Diff: tests/pio_tests/scenarios/basic_app_usecases.py ---
    @@ -61,17 +61,13 @@ class BasicAppUsecases(BaseTestCase):
       def setUp(self):
         random.seed(3)
         self.log.info("Setting up the engine")
    -
    -    template_path = pjoin(
    -        self.test_context.engine_directory, "recommendation-engine")
    +    template_path = 
"https://github.com/chanlee514/template-scala-parallel-recommendation";
    --- End diff --
    
    That's a good idea. In fact, the templates have been donated and are in the 
process of migrating to Apache. I will ping you when that's done, so you can 
start using those new Git URLs as well.


> Add integration tests for major templates
> -----------------------------------------
>
>                 Key: PIO-35
>                 URL: https://issues.apache.org/jira/browse/PIO-35
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Chan
>
> Developers of engine templates should be able to test that their template 
> works with the latest changes in PredictionIO. As a starting point, we can 
> expand the integration test suite to all previously "official" templates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to