[ 
https://issues.apache.org/jira/browse/PIO-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851646#comment-15851646
 ] 

Alexander  Merritt edited comment on PIO-45 at 2/3/17 4:00 PM:
---------------------------------------------------------------

[~pferrel] 
The code was not accounting for arrays in property values, while your python 
import script makes everything into an array.
I have a fix for this, just need to clean it up & test a bit more.

The second issue you mention, I'm not entirely clear on. Do you mean that $sets 
that fall outside the window are filtered out?
If so, I have the fix for that as well. Compressed $set / $unset falling 
outside the window will be kept.



was (Author: emergentorder):
[~pferrel] 
The code was not accounting for arrays in property values, while your python 
import script makes everything into a array.
I have a fix for this, just need to clean it up & test a bit more.

The second issue you mention, I'm not entirely clear on. Do you mean that $sets 
that fall outside the window are filtered out?
If so, I have the fix for that as well. Compressed $set / $unset falling 
outside the window will be kept.


> SelfCleaningDatasource erases all data
> --------------------------------------
>
>                 Key: PIO-45
>                 URL: https://issues.apache.org/jira/browse/PIO-45
>             Project: PredictionIO
>          Issue Type: Bug
>    Affects Versions: 0.10.0-incubating
>            Reporter: Pat Ferrel
>            Assignee: Alexander  Merritt
>            Priority: Blocker
>             Fix For: 0.11.0
>
>         Attachments: import_handmade_simple.py, 
> sample-time-window-and-downsample-data.txt
>
>
> as integrated into the UR, in the integration-test, the SelfCleaningDataset 
> erases all data. This feature works fine in the AML version of PIO.
> Although not tested one could assume that this would be true with any other 
> Datasource in other templates.
> [~emergentorder] can you check to see if the PIO merge was done correctly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to