[
https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891542#comment-15891542
]
ASF GitHub Bot commented on PIO-56:
-----------------------------------
GitHub user lucasbm88 opened a pull request:
https://github.com/apache/incubator-predictionio/pull/355
[PIO-56] Adding embedded elasticsearch and mocked configuration for tests
This pull request will add a code that will avoid the need of an
elasticsearch installation and pio-env configuration when running unit tests of
the project core.
Basically the changes are:
- Adding scalamock as a dependency for project core
- Modifying data Storage.scala file to allow mocked configuration
- Creating a new helper object to start and shutdown embedded elasticsearch
- Modifying existing tests to use new infrastructure.
More details of the issue in ASF Jira:
https://issues.apache.org/jira/browse/PIO-56
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lucasbm88/incubator-predictionio develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
----
commit 077b18a5bd83f81d0e5152e197f1590fa69ba6f6
Author: administrador <administrador@administradors-macbook-pro.local>
Date: 2017-03-02T02:48:28Z
Adjusting the project core tests and Storage object in order to use an
embedded elasticsearch and mocked METADATA configuration on unit tests. Fix for
#PIO-56
----
> Unit tests in module core should not require real setup
> -------------------------------------------------------
>
> Key: PIO-56
> URL: https://issues.apache.org/jira/browse/PIO-56
> Project: PredictionIO
> Issue Type: Improvement
> Affects Versions: 0.10.0-incubating
> Environment: Tested with Mac OS X, i7, 8GB
> Reporter: Lucas Bonatto Miguel
> Labels: development_environment
> Fix For: 0.11.0
>
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the
> project core via sbt, one will face an error stating that the METADATA
> configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource
> (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external
> installation/configuration:
> - Developers would have an easy setup of the environment.
> - Continuous integration would be easier
> How to reproduce:
> - Download predictionio from github
> - In root folder run ./make-distribution.sh
> - In root folder run sbt core/test
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
