[ 
https://issues.apache.org/jira/browse/PIO-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900511#comment-15900511
 ] 

ASF GitHub Bot commented on PIO-49:
-----------------------------------

Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/352
  
    @marevol Really appreciate this great piece of work! I am planning to make 
a few minor changes after merging this:
    
    * Make Elasticsearch 1 assembly default (by putting that in `lib/spark` 
instead of using the ES5 assembly. This is to make sure we allow enough time 
for deprecation.
    * Adjust integration tests accordingly.
    * Add integration tests for both ES1 and ES5.
    * Add a switch in `make-distribution.sh --use-es5` for building a 
distribution as is this pull request.
    
    Please let me know how you think. The goal is to allow people to upgrade to 
0.11 without changing configuration files. We will announce loudly that we will 
deprecate ES1 and make it non-default in 0.12.


> Add support for Elasticsearch 5.x
> ---------------------------------
>
>                 Key: PIO-49
>                 URL: https://issues.apache.org/jira/browse/PIO-49
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Shinsuke Sugaya
>
> We work on meta/event storage support for Elasticsearch 5.x.
> Although Elasticsearch 2.x does not allow dots in field names,
> Elasticsearch 5.x supports it. So, it's better to upgrade to ES 5.x release.
> Since ES 5.x provides Java Rest API client, we replaced
> Transport communication with HTTP one. Therefore, our fix
> uses HTTP(9200 port) only.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to