Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/357#discussion_r105085253
--- Diff:
tools/src/main/scala/org/apache/predictionio/tools/console/Console.scala ---
@@ -734,7 +734,7 @@ object Console extends Logging {
}
}
- def getEngineInfo(jsonFile: File): EngineInfo = {
+ def getEngineInfo(jsonFile: File, engineDir: Option[String]): EngineInfo
= {
--- End diff --
@chanlee514 should we just pass in a `String` here? It doesn't look like
there would be a case for `None`. It also looks like
`o.a.p.tools.Common.getEngineDirPath` has already taken care of getting the
current working directory, so I think it should be safe to just drop using
`user.dir` completely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
