[ 
https://issues.apache.org/jira/browse/PIO-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986623#comment-15986623
 ] 

ASF GitHub Bot commented on PIO-61:
-----------------------------------

Github user marevol commented on a diff in the pull request:

    
https://github.com/apache/incubator-predictionio/pull/371#discussion_r113695041
  
    --- Diff: storage/s3/build.sbt ---
    @@ -0,0 +1,44 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +import PIOBuild._
    +
    +name := "apache-predictionio-data-s3"
    +
    +libraryDependencies ++= Seq(
    +  "org.apache.predictionio" %% "apache-predictionio-core" % version.value 
% "provided",
    +  "com.google.guava"        % "guava"                     % "14.0.1"      
% "provided",
    +  "com.amazonaws"           % "aws-java-sdk-s3"           % "1.11.118",
    +  "org.scalatest"           %% "scalatest"                % "2.1.7" % 
"test")
    +
    +parallelExecution in Test := false
    +
    +pomExtra := childrenPomExtra.value
    +
    +assemblyOption in assembly := (assemblyOption in 
assembly).value.copy(includeScala = false)
    +
    +assemblyShadeRules in assembly := Seq(
    +  ShadeRule.rename("org.apache.http.**" -> 
"shadeio.data.s3.http.@1").inAll,
    +  ShadeRule.rename("com.fasterxml.**" -> 
"shadeio.data.s3.fasterxml.@1").inAll
    +)
    --- End diff --
    
    Checking on Scala 2.11/Spark 2.1/ES 5.1&5.3, I could not reproduce it yet...
    My test script file is 
[test_all.sh](https://github.com/jpioug/incubator-predictionio/blob/express-v1/test_all.sh)
 to build pio and run recommender template.
    Is it reproduced in Docker tests? I'd like to know steps to reproduce it...


> Add S3 Model Data Repository
> ----------------------------
>
>                 Key: PIO-61
>                 URL: https://issues.apache.org/jira/browse/PIO-61
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Shinsuke Sugaya
>
> To put/get model data to AWS S3 directly, using aws-java-sdk-s3, add 
> storage/s3 implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to