[ 
https://issues.apache.org/jira/browse/PIO-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030568#comment-16030568
 ] 

ASF GitHub Bot commented on PIO-90:
-----------------------------------

GitHub user takezoe opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/386

    [PIO-90] Improve /batch/events.json endpoint performance

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/takezoe/incubator-predictionio 
improve_batch_insert_performance

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #386
    
----
commit fe9c40c90fc13e3bb3c0a78f1e0870f56e684a4f
Author: Naoki Takezoe <take...@apache.org>
Date:   2017-05-29T08:04:50Z

    Add LEvent.futureInsertBatch and modify EventServer to use it

commit 1252c972fcab44b229f741c1f4345a92b5053cd6
Author: Naoki Takezoe <take...@apache.org>
Date:   2017-05-29T09:57:21Z

    Implement futureInsertBatch for Elasticsearch 5.x

commit e082d5383a55ff2b4a8431c7ce375258f6e79c7b
Author: Naoki Takezoe <take...@apache.org>
Date:   2017-05-29T11:05:29Z

    Implement futureInsertBatch for JDBC storage

----


> Improve /batch/events.json endpoint performance
> -----------------------------------------------
>
>                 Key: PIO-90
>                 URL: https://issues.apache.org/jira/browse/PIO-90
>             Project: PredictionIO
>          Issue Type: Improvement
>            Reporter: Naoki Takezoe
>            Assignee: Naoki Takezoe
>
> It's possible to improve /batch/events.json endpoint of the event server 
> performance by using batch inserting in storage implementations. For example, 
> Elasticsearch has bulk API and also JDBC has batch updating.
> I propose adding LEvent.futureInsertBatch() that takes Seq[Event] and modify 
> /batch/events.json endpoint to use it. The default implementation is calling 
> existing futureInsert() per event, and we can override it in the storage 
> implementation to use storage specific batch inserting API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to