Chickenzilla commented on a change in pull request #23:
URL: https://github.com/apache/pulsar-dotpulsar/pull/23#discussion_r449513485
##########
File path: src/DotPulsar/DotPulsar.csproj
##########
@@ -23,7 +23,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.ObjectPool"
Version="3.1.5" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0"
PrivateAssets="All" />
- <PackageReference Include="protobuf-net" Version="2.4.6" />
+ <PackageReference Include="protobuf-net" Version="2.3.*" />
Review comment:
Ahh, so this is because we use an older version of protobuf in our
infrastructure and it's so core to our platform we're risk averse to upgrading,
and the pulsar client doesn't need any fancy version to work. I did not mean
to include that change in this PR; I would understand if the library wanted to
use the fastest features, though I'm intrigued by how Elasticsearch.net
includes Newtonsoft.Json (I'm unfamiliar with the paradigm) as being able to
support older versions would likely help adoption?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
