massakam commented on a change in pull request #130:
URL: https://github.com/apache/pulsar-client-node/pull/130#discussion_r505410319
##########
File path: src/Consumer.cc
##########
@@ -133,10 +135,19 @@ class ConsumerNewInstanceWorker : public
Napi::AsyncWorker {
}
this->done = false;
- if (topic.empty()) {
+ if (!topicsPattern.empty()) {
pulsar_client_subscribe_pattern_async(this->cClient,
topicsPattern.c_str(), subscription.c_str(),
this->consumerConfig->GetCConsumerConfig(),
&ConsumerNewInstanceWorker::subscribeCallback, (void *)this);
+ } else if (topics.size() > 0) {
+ const char **c_topics = new const char *[topics.size()];
Review comment:
Is there any reason why this variable is not in camel case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
