dlg99 commented on a change in pull request #22:
URL: https://github.com/apache/pulsar-adapters/pull/22#discussion_r654211393
##########
File path:
pulsar-client-kafka-compat/pulsar-client-kafka_0_8/src/test/java/org/apache/pulsar/client/kafka/test/KafkaProducerSimpleConsumerTest.java
##########
@@ -141,6 +141,7 @@ public void testPulsarKafkaProducerWithSerializer(int
partitions) throws Excepti
producer.send(message);
}
producer.close();
+ Thread.sleep(500);
Review comment:
I agree that it would be nice, but I suggest we merge this to unblock
the release + add an issue to fix it later (it will take time to figure out
what to wait for specifically, especially given that this test failed only on
CI and passed on local runs) + there are other tests that rely on sleep:
https://github.com/apache/pulsar-adapters/search?q=Thread.Sleep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
