On 2021/09/10 06:22:09, PengHui Li <peng...@apache.org> wrote:
> Looks good overall,
>
> Do we need to consider the batch filter since the API is defined as
> `Message`, not `Entry`, so parts of the batch need to filter out, does it
> should be handled by Filter, or the consumer side, or the producer side?
>
> Thanks,
> Penghui
>
Hi Penghui:
In my opinion
1) It should be the Entry dimension, and the execution should be before
AbstractBaseDispatcher#filterEntriesForConsumer, so that custom filtering can
be performed before the data is affected
2) It should be filtered on the Broker side, which can reduce the transmission
of unnecessary data
Thanks
