+1 to this proposal, may be we need a master issue for tracking all the components? so that we can have more participants.
Thanks, Penghui On Tue, Sep 21, 2021 at 3:39 PM Enrico Olivelli <[email protected]> wrote: > Marvin, > > Il Mar 21 Set 2021, 04:49 Zhengxin Cai <[email protected]> ha scritto: > > > Hi Pulsar Community, > > > > I'd like to propose that we introduce Maven Modernizer[1] plugin into > > Pulsar project. > > This plugin helps detecting uses of legacy APIs which can be replaced > with > > modern APIs that are often more performant, safer, and idiomatic than the > > legacy equivalents. It's already used by some other open source projects > > like Apache JCloud, PrestoDB and Trino. > > Some examples: > > Replace Guava Maps.newHashMap() with new java.util.HashMap<>(), > > Replace Guava Objects.hashCode with java.util.Objects.hash() > > Replace Guava checkNotNull with java.util.Objects.requireNonNull() > > I think by introducing Modernizer plugin we can eliminate the use of some > > legacy APIs and unify some of our API usage to create a more consistent > > code base. > > > > Do you have a plan? > Is it about adding a plugin and then fixing all the findings? > > Did you try it already? > Do you have an estimate of the number of warnings? > > I am +1 to this proposal, but let's draw a plan (possibly a PIP) > > > Cheers > Enrico > > > > Best, > > Marvin, > > > > [1] https://github.com/gaul/modernizer-maven-plugin > > >
