+1 (non-binding)

* Verified checksum/signature
* Ran release candidate validation on JDK8+macOS

Thank you for being release manager.

nits:
Do we apply the https://github.com/apache/pulsar/pull/12659 commit to v2.9.0?
In my environment, StringIndexOutOfBoundsException occurs when I create a 
tenant.
I think it is not critical at least in my case because of 
https://github.com/apache/pulsar/blob/v2.9.0-candidate-4/pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupNamespaceConfigListener.java#L139-L141
 .
What do you think?

```
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1931) ~[?:1.8.0_312]
        at 
org.apache.pulsar.broker.resources.NamespaceResources.pathIsFromNamespace(NamespaceResources.java:121)
 ~[org.apache.pulsar-pulsar-broker-common-2.9.0.jar:2.9.0]
        at 
org.apache.pulsar.broker.resourcegroup.ResourceGroupNamespaceConfigListener.accept(ResourceGroupNamespaceConfigListener.java:139)
 ~[org.apache.pulsar-pulsar-broker-2.9.0.jar:2.9.0]
        at 
org.apache.pulsar.broker.resourcegroup.ResourceGroupNamespaceConfigListener.accept(ResourceGroupNamespaceConfigListener.java:42)
 ~[org.apache.pulsar-pulsar-broker-2.9.0.jar:2.9.0]
        at 
org.apache.pulsar.metadata.impl.AbstractMetadataStore.lambda$receivedNotification$0(AbstractMetadataStore.java:167)
 ~[org.apache.pulsar-pulsar-metadata-2.9.0.jar:2.9.0]
        at 
java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:895)
 ~[?:1.8.0_312]
        at 
org.apache.pulsar.metadata.impl.AbstractMetadataStore.lambda$receivedNotification$1(AbstractMetadataStore.java:165)
 ~[org.apache.pulsar-pulsar-metadata-2.9.0.jar:2.9.0]
        at 
java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
 [?:1.8.0_312]
        at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_312]
        at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_312]
        at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
 [io.netty-netty-common-4.1.68.Final.jar:4.1.68.Final]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_312]
```

Regards,
-- 
Yuri Mizushima
yumiz...@yahoo-corp.jp
 

"Enrico Olivelli" <eolive...@gmail.com> wrote:

    I have pushed in my personal dockerhub the docker images for this RC:

    eolivelli/pulsar-all:2.9.0rc4
    eolivelli/pulsar:2.9.0rc4

    Enrico

    Il giorno mer 17 nov 2021 alle ore 14:04 Enrico Olivelli <
    eolive...@gmail.com> ha scritto:

    > This is the fourth release candidate for Apache Pulsar, version 2.9.0.
    >
    > It fixes the following issues:
    > https://github.com/apache/pulsar/milestone/30?closed=1
    >
    > *** Please download, test and vote on this release. This vote will stay 
open
    > for at least 72 hours ***
    >
    > Note that we are voting upon the source (tag), binaries are provided for
    > convenience.
    >
    > Source and binary files:
    > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-2.9.0-candidate-4/
    >
    > SHA-512 checksums:
    >
    > 
659afa98e2475fc95f3126aab47d365e3e43a9d419c9cbe20c99520029f0b28aec2f471da5ccf47b92017a4c7943fc113a96232b075eb675e2b9df3601b2a7ad
  apache-pulsar-2.9.0-SNAPSHOT-bin.tar.gz
    > 
ed93aa1b57411c5d153bcd1433db6679ddb9b4d23896b39c1a1ad8edc70aaa7e95842a5770d6d55b466ab90500e17f50549673601556e767f7c12135ae360e85
  apache-pulsar-2.9.0-SNAPSHOT-src.tar.gz
    >
    > Maven staging repo:
    > https://repository.apache.org/content/repositories/orgapachepulsar-1104/
    >
    > The tag to be voted upon:
    > v2.9.0-candidate-4 (bdd57b21a66b81aab72c4ec39d516ffd2a769c35)
    > https://github.com/apache/pulsar/releases/tag/v2.9.0-candidate-4
    >
    > Pulsar's KEYS file containing PGP keys we use to sign the release:
    > https://dist.apache.org/repos/dist/dev/pulsar/KEYS
    >
    > Please download the source package, and follow the README to build
    > and run the Pulsar standalone service.
    >
    > Enrico Olivelli
    >
    >

Reply via email to