+1 Enrico
Il Gio 23 Dic 2021, 19:01 Matteo Merli <matteo.me...@gmail.com> ha scritto: > +1 > > On Thu, Dec 23, 2021 at 9:53 AM Michael Marshall <mmarsh...@apache.org> > wrote: > > > Update: the PR [0] to remove the grafana docker image is now merged. I > > still need reviews for the PR to remove the Prometheus docker image > > [1]. I will follow up with a PR to remove the DCOS example. > > > > Thanks, > > Michael > > > > [0] https://github.com/apache/pulsar/pull/13389 > > [1] https://github.com/apache/pulsar/pull/13387 > > > > On Mon, Dec 20, 2021 at 1:29 PM Michael Marshall <mmarsh...@apache.org> > > wrote: > > > > > > Hi Pulsar Community, > > > > > > I would like to clean up our main project's `docker/` directory. We > > > have a couple of old Dockerfiles that either need to be updated or > > > removed. My vote is to remove them. > > > > > > 1. Grafana: with every release, we build and upload a custom grafana > > > docker image just to package dashboards. Grafana provides other > > > mechanisms to load dashboards. I propose we remove the grafana image > > > from our release process and then move our dashboard json files to a > > > new top level directory named `grafana/`. [0] > > > > > > Our image is based on grafana/grafana:4.3.1. The current grafana > > > release is grafana/grafana:8.3.3. > > > > > > 2. Prometheus: we have a prometheus Dockerfile that was initially > > > merged as part of a DCOS example 4 years ago. We have never published > > > this docker image as part of a release [1]. There is nothing pulsar > > > specific in these files. [2] > > > > > > Our image is based on prom/prometheus:v1.8.2. The latest prometheus > > > image prom/prometheus:v2.32.1. > > > > > > 3. Can we remove our DCOS examples in `deployment/dcos`? We haven't > > > updated our DCOS example deployment spec in 3.5 years. The current > > > spec relies on our custom grafana docker image and on a community > > > member's custom build [3] of our prometheus-dcos docker image. I don't > > > think our example deployment should rely on a community member's > > > custom docker image. (I don't have a PR to remove this example yet.) > > > > > > Alternatively, we could update the dockerfiles and the DCOS example. > > > However, the lack of activity in keeping these three project > > > dependencies up to date indicates to me that we should remove them. > > > > > > Let me know what you think. > > > > > > Thanks, > > > Michael > > > > > > [0] https://github.com/apache/pulsar/pull/13389 > > > [1] https://hub.docker.com/u/apachepulsar/ > > > [2] https://github.com/apache/pulsar/pull/13387 > > > [3] > > > https://github.com/apache/pulsar/blob/c62ca808fc8c5aed3bb96b99bf6ef0c8ed382e3f/deployment/dcos/PulsarGroups.json#L251 > > > -- > -- > Matteo Merli > <matteo.me...@gmail.com> >
