Enrico > What do you mean with 'redelivery backorder has not been released yet'?
I think you mean "redelivery backoff has not been released yet"? This proposal changed the public APIs, but the changed APIs are introduced by https://github.com/apache/pulsar/pull/12566, we don't have a release contains the APIs that introduced in #12566, so we are safe the API. The behavior will not be changed in this proposal, we just have an additional API for users to achieve the flexible message redelivery control, will not change the behavior we have. > Pulsar client and Consumer are configurable using a map of key value pairs. So we must take care of not changing the behaviour. The proposal will not add more fields to the consumer configuration data, Just change the class name here https://github.com/apache/pulsar/blob/f0da648ae1c02248c015d26b93e08b2a9a78c1d3/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java#L78 Regards, Penghui On Tue, Dec 28, 2021 at 3:19 PM Enrico Olivelli <eolive...@gmail.com> wrote: > Penghui > > I am overall +1 to this proposal but I am afraid about compatibility. Amd I > won't to be sure that we are not breaking anything. > Pulsar client and Consumer are configurable using a map of key value pairs. > So we must take care of not changing the behaviour. > > What do you mean with 'redelivery backorder has not been released yet'? > > > Enrico > > Il Lun 27 Dic 2021, 14:25 PengHui Li <peng...@apache.org> ha scritto: > > > https://github.com/apache/pulsar/issues/13528 > > > > Pasted below for quoting convenience. > > > > ----- > > > > PIP 130: Apply redelivery backoff policy for ack timeout > > > > ## Motivation > > > > PIP 106 > > > > > https://github.com/apache/pulsar/wiki/PIP-106%3A-Negative-acknowledgment-backoff > > introduced negative acknowledgment message redelivery backoff which > allows > > users to achieve > > more flexible message redelivery delay time control. But the redelivery > > backoff policy only > > apply to the negative acknowledgment API, for users who use ack timeout > to > > trigger the message > > redelivery, not the negative acknowledgment API, they can't use the new > > features introduced by > > PIP 106. > > > > So the proposal is to apply the message redelivery policy for the ack > > timeout mechanism. > > Users can specify an ack timeout redelivery backoff, for example, apply > an > > exponential backoff > > with 10 seconds ack timeout: > > > > ```java > > client.newConsumer() > > .ackTimeout(10, TimeUnit.SECOND) > > .ackTimeoutRedeliveryBackoff( > > ExponentialRedeliveryBackoff.builder() > > .minDelayMs(1000) > > .maxDelayMs(60000).build()); > > .subscribe(); > > ``` > > > > The message redelivery behavior should be: > > > > | Redelivery count | Redelivery delay | > > | ---- | ---- | > > | 1 | 10 + 1 seconds | > > | 2 | 10 + 2 seconds | > > | 3 | 10 + 4 seconds | > > | 4 | 10 + 8 seconds | > > | 5 | 10 + 16 seconds | > > | 6 | 10 + 32 seconds | > > | 7 | 10 + 60 seconds | > > | 8 | 10 + 60 seconds | > > > > ## Goal > > > > Add an API to the Java Client to provide the ability to specify the ack > > timeout message redelivery > > backoff and the message redelivery behavior should abide by the > redelivery > > backoff policy. > > > > > > ## API Changes > > > > 1. Change `NegativeAckRedeliveryBackoff` to `RedeliveryBackoff`, so that > we > > can use the > > MessageRedeliveryBackoff for both negative acknowledgment API and ack > > timeout message redelivery. > > > > 2. Change `NegativeAckRedeliveryExponentialBackoff` to > > `ExponentialRedeliveryBackoff`, and add `multiplier` > > for `RedeliveryExponentialBackoff` with default value 2. > > > > ExponentialRedeliveryBackoff.builder() > > .minDelayMs(1000) > > .maxDelayMs(60000) > > .multiplier(5) > > .build() > > > > 3. Add `ackTimeoutRedeliveryBackoff` method for the `ConsumerBuilder`: > > > > ```java > > client.newConsumer() > > .ackTimeout(10, TimeUnit.SECOND) > > .ackTimeoutRedeliveryBackoff( > > ExponentialRedeliveryBackoff.builder() > > .minDelayMs(1000) > > .maxDelayMs(60000).build()); > > .subscribe(); > > ``` > > > > ## Compatibility and migration plan > > > > Since the negative acknowledgment message, redelivery backoff has not > been > > released yet, > > so we can modify the API directly. > > > > ## Tests plan > > > > - Verify the introduced `multiplier` of ExponentialRedeliveryBackoff > > - Verify the ack timeout message redelivery work as expected > > > > Regards, > > Penghui > > >
