michaeljmarshall commented on a change in pull request #155:
URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r790222142
##########
File path: charts/pulsar/values.yaml
##########
@@ -988,6 +988,24 @@ grafana:
requests:
memory: 250Mi
cpu: 0.1
+ volumes:
+ # use a persistent volume or emptyDir
+ persistence: true
Review comment:
I agree there is a chance for confusion. However, the official Grafana
helm chart disables persistence by default, so I think we should too.
https://github.com/grafana/helm-charts/blob/2a422f6c43c3db33d31fc12d23957d5b6ff5e8c6/charts/grafana/values.yaml#L275-L277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
