mkoertgen edited a comment on pull request #227:
URL: 
https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1055315804


   Hi @michaeljmarshall ,
   
   Yes, meanwhile the prom-operator-team fixed labelmap validation, so this PR 
can probably be skipped & closed without merging. 
   Users should be referred to upgrading prom-operator.
   
   We could still ask ourselves why mapping all labels from the pod is a good 
idea, though. 
   In my humble opinion, users should be advised to add labels directly to the 
servicemonitor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to