urfreespace commented on code in PR #183:
URL: https://github.com/apache/pulsar-site/pull/183#discussion_r956844216
##########
site2/tools/publish-website.sh:
##########
@@ -52,11 +51,7 @@ PULSAR_SITE_TMP=/tmp/pulsar-site
mkdir -p $PULSAR_SITE_TMP/content/
fi
- echo "BUILD_ALL:"$BUILD_ALL
- if [[ $BUILD_ALL"" == "11" ]]; then
- echo "clean all the old random js files because a new all version build
done, all the js is regenerated with a random name"
- rm -rf $PULSAR_SITE_TMP/content/assets/js
- fi
+ rm -rf $PULSAR_SITE_TMP/content/*
Review Comment:
you can't remove all content every time, just when the website has a full
build, you can do that, in fact, we just build the versions which have files
changes, just once full build(all versions and all languages) one day, so these
code can't be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
