Hi- Sent from my iPhone
> On Dec 6, 2022, at 8:40 PM, mattisonc...@gmail.com wrote: > > Hi, All > > Recently, I realised we don't have any rules for breaking pulsar broker > public API. [1] While I agree with you that we need to be transparent about changing APIs you mention a specific PR. It would help me understand if you would explain how apis were changed in this PR along with how PIP-138 was not properly discussed. > > Since pulsar has extended abilities like protocol handler, additional > servlet, interceptor etc., many libraries rely on broker public API. > I'm not sure if we've got to ensure compatibility for this. Otherwise, it > introduces much work in resolving compatibility for other OSS contributors. We should be sure to track and then highlight API changes in release documents. API changes should be held until the next major version (now 2.12) and be documented with that release. I think we need to be explicit in our GitHub PR template. I don’t have a suggested edit yet, but the idea is to add text about 1. How the PR changes the API 2. Which PIP authorizes it Best, Dave > > Best, > Mattison > > > [1] https://github.com/apache/pulsar/pull/16425
