Hi Zike, thanks for your great job!
Verified:
- Verified checksum and signatures
- Build from source code on Ubuntu 20.04
- Verified produce and test on DEB followed by [0]
I found the following issues.
- When running produce and consume, and the client calls close, it
shows `ConnectError` in the close method
```
2022-12-09 03:33:45.288 INFO [139648501270080] ConsumerImpl:1083 |
[persistent://public/default/basic_e2e_example, sub, 0] Closed
consumer 0
2022-12-09 03:33:45.289 INFO [139648476091968] ClientConnection:1584
| [127.0.0.1:43644 -> 127.0.0.1:6650] Connection closed with
ConnectError
2022-12-09 03:33:45.289 INFO [139648476091968] ClientConnection:267 |
[127.0.0.1:43644 -> 127.0.0.1:6650] Destroyed connection
```
- When build the source code with g++ 11.3.0, it failed with the
following exception
```
/usr/include/c++/11/ostream:750:5: error: no type named 'type' in
'struct std::enable_if<false, void>'
In file included from /usr/include/gtest/internal/gtest-internal.h:57,
from /usr/include/gtest/gtest.h:62,
from
/home/apache-pulsar-client-cpp-3.1.0/tests/KeyValueSchemaTest.cc:19:
```
- When build perf under perf directory, it failed with the following exception.
```
root@5b313881db52:/home/apache-pulsar-client-cpp-3.1.0/perf/build# make
[ 25%] Building CXX object CMakeFiles/perfProducer.dir/PerfProducer.o
/home/apache-pulsar-client-cpp-3.1.0/perf/PerfProducer.cc:19:10: fatal
error: lib/LogUtils.h: No such file or directory
19 | #include <lib/LogUtils.h>
| ^~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/perfProducer.dir/build.make:76:
CMakeFiles/perfProducer.dir/PerfProducer.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/perfProducer.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
```
[0] https://github.com/BewareMyPower/pulsar-client-cpp-demo
Thanks,
Hang
PengHui Li <peng...@apache.org> 于2022年12月5日周一 16:23写道：
>
> +1 binding
>
> - Verified the signatures
> - Verified the Linux platform follows the documentation [0]
> - RPM
> - DEB
> - APK
>
> [0] https://github.com/BewareMyPower/pulsar-client-cpp-demo
>
> Thanks,
> Penghui
>
> On Fri, Dec 2, 2022 at 2:06 PM Matteo Merli <matteo.me...@gmail.com> wrote:
>
> > +1 binding.
> >
> > Checked:
> > * Source compiling and tested with perf producer
> > * Signatures
> > * RPM & Deb packages installing
> >
> >
> > --
> > Matteo Merli
> > <matteo.me...@gmail.com>
> >
> > On Thu, Dec 1, 2022 at 5:57 PM Zike Yang <z...@apache.org> wrote:
> > >
> > > This is the third release candidate for Apache Pulsar Client C++,
> > > version 3.1.0.
> > >
> > > It fixes the following issues:
> > > https://github.com/apache/pulsar-client-cpp/milestone/2?closed=1
> > >
> > > *** Please download, test and vote on this release. This vote will stay
> > open
> > > for at least 72 hours ***
> > >
> > > Note that we are voting upon the source (tag), binaries are provided for
> > > convenience.
> > >
> > > Source and binary files:
> > >
> > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.1.0-candidate-3/
> > >
> > > SHA-512 checksums:
> > >
> > a09cbf9c3e1208545ed9150a4ff6cba20cb29d01a3c8177aa9f17aa2285a080e19a4cd146a73e5bdbfd165562c4e63beb1aef7a3c655dd7fe01a9a92139dd0ac
> > > ./apache-pulsar-client-cpp-3.1.0.tar.gz
> > >
> > > The tag to be voted upon:
> > > v3.1.0-candidate-3 (f9cca17b5bb90819be78eabf921d60c99cf02a13)
> > >
> > https://github.com/apache/pulsar-client-cpp/releases/tag/v3.1.0-candidate-3
> > >
> > > Pulsar's KEYS file containing PGP keys you use to sign the release:
> > > https://dist.apache.org/repos/dist/dev/pulsar/KEYS
> > >
> > > Please download the source package, and follow the README to compile and
> > test.
> > >
> > > Thanks,
> > > Zike Yang
> >
