Thanks, tison and Michael! I've added one workflow that needs to be updated as Michael talked about the PR template [1]
https://github.com/apache/pulsar/issues/19111#issuecomment-1370596495 On Wed, Jan 4, 2023 at 1:34 PM Michael Marshall <mmarsh...@apache.org> wrote: > > I'd prefer not to put too many things in the template. > > I agree with this sentiment. I think the template is already too busy. > Many active contributors ignore important sections leaving them with > the default text. > > However, I think a link pointing to where to contribute documentation > would help new contributors. We could also point contributors to the > contribution guide. > > I recently contributed to kedacore/keda and they had a concise > template that was intuitive and had several links [0]. > > Thanks, > Michael > > [0] > https://raw.githubusercontent.com/kedacore/keda/main/.github/PULL_REQUEST_TEMPLATE.md > > On Tue, Jan 3, 2023 at 11:23 PM tison <wander4...@gmail.com> wrote: > > > > Thanks for your feedback! > > > > Michael: > > > > I've updated the "Edit this page" link to jump to the site repo and the > > Documentation guide should properly describe the process. Do you find > some > > incorrect content in the PR template? Otherwise, I'd prefer not to put > too > > many things in the template. > > > > Best, > > tison. > > > > > > Michael Marshall <mmarsh...@apache.org> 于2023年1月4日周三 13:09写道： > > > > > Thanks for all of your work on this! > > > > > > One follow up is that we should update the PR template [0] so that > > > contributors know where to contribute documentation. > > > > > > Thanks, > > > Michael > > > > > > [0] > > > > https://github.com/apache/pulsar/blob/9ec1d071c7188a2db694e9d7b359faaf33cb076e/.github/PULL_REQUEST_TEMPLATE.md > > > > > > On Tue, Jan 3, 2023 at 8:29 PM Yu <li...@apache.org> wrote: > > > > > > > > Hi tison, thanks for your great work! > > > > > > > > On Fri, Dec 30, 2022 at 6:41 PM tison <wander4...@gmail.com> wrote: > > > > > > > > > Hi, > > > > > > > > > > With the resolution of [1], I moved the source of the Pulsar > document > > > to > > > > > the site repo[2][3][4][5]. > > > > > > > > > > Now, if you'd like to update Pulsar document, you should submit a > PR > > > > > against the site repo (apache/pulsar-site) instead of the main repo > > > > > (apache/pulsar, the site2 folder). > > > > > > > > > > I've updated the Edit URL on the page[6], so if you click the "Edit > > > this > > > > > page" button, you will be guided to the correct place. > > > > > > > > > > The docs layout is almost the same as former site2 folder. I'll > update > > > the > > > > > corresponding contribution guide and release guide later. You can > keep > > > an > > > > > eye on the tracking issue[7]. > > > > > > > > > > Best, > > > > > tison. > > > > > > > > > > [1] > https://lists.apache.org/thread/89wl112cflvtoyfg3l7kglr1dozsljm9 > > > > > [2] https://github.com/apache/pulsar-site > > > > > [3] https://github.com/apache/pulsar/pull/19100 > > > > > [4] https://github.com/apache/pulsar-site/pull/348 > > > > > [5] https://github.com/apache/pulsar/issues/19090 > > > > > [6] > > > > > > > > > > > > > > https://github.com/apache/pulsar-site/commit/a2c2d23c21fd9cf936a4381901001b5889973d8e > > > > > [7] https://github.com/apache/pulsar/issues/19064 > > > > > > > > >
