Hi, Baodi,

> I don't think it's a good idea to upload (napi-xx.tar.gz) to npm, these files 
> are tens of MB in total, and it doesn't solve the problem that the release rc 
> version needs to change the address.

If we add `Pulsar.node` (which currently included in napi-xx.tar.gz)
to npm package file, then the npm will not need to download the
Pulsar.node file from an external URL. In this way, we no longer need
to specify the binary path. Is it possible to be implemented? It seems
this should solve the issue of release rc package.

Regarding the file size issue, The key point is whether we can make
npm use different package files on different platforms, so we don't
need to put all the Pulsar.node files of all platforms in one npm
package file.

> I think we can provide scripts to automatically modify these addresses and 
> modify the release process documentation to explain the steps of release rc 
> separately.

That's a good idea. And I'm working on this.

BR,
Zike Yang

On Sat, Jan 7, 2023 at 11:21 AM Baodi Shi <baodi....@icloud.com.invalid> wrote:
>
> Hi, Zike:
>
>
> > However, doing so also creates some inconvenience for the release
> > process. I was wondering if we could put these files(napi-xxx.tar.gz)
> > in the npm package file.
> > Do you have any ideas?
>
> I don't think it's a good idea to upload (napi-xx.tar.gz) to npm, these files 
> are tens of MB in total, and it doesn't solve the problem that the release rc 
> version needs to change the address.
>
> I think we can provide scripts to automatically modify these addresses and 
> modify the release process documentation to explain the steps of release rc 
> separately.
>
>
> Thanks,
> Baodi Shi

Reply via email to