The topic name character validation is already done by
`NamedEntity#checkName`. And I agree that the system topic should be
taken carefully as well. But I have a concern that whether we should
treat all topics that start with the long underscore ("__") as system
topics? Users might have defined their own "system topics" that start
with the long underscore for special uses.If yes, how would you like to allow users to access the system topics? In Kafka, there are a few (only two, IIRC) special topics that only allow non-admin users to read, which means users cannot write to these topics or delete them. Thanks, Yunze On Thu, Feb 2, 2023 at 10:52 AM Yong Zhang <zhangyong1025...@gmail.com> wrote: > > Mattison, > > I agree with you about restricting the topic name. > > How about using a blacklist way to restrict it? > > We can have a blacklist on the topic name restriction and make it > configurable. Add the keywords you mentioned in the default configuration. > That would have a more general way to block a topic name creation. > If we have more restrictions on the topic name in the future, this way > can make it easy to fit them without changing any code. > > Thanks, > Yong > > On Thu, 2 Feb 2023 at 07:33, <mattisonc...@gmail.com> wrote: > > > Hi, All > > > > In the current implementation, pulsar didn't support topic name > > restriction. It's a good chance to discuss it. > > > > I think this discussion aims to identify what types of topic names we all > > need to restrict. > > > > I know three topic names that need to be restricted at the moment. > > > > 1. The `-partition-` keyword. > > 2. Topic name characters validation. > > 3. System topic prefix `__`. > > > > > > Please feel free to leave your comments. > > I will keep this discussion for a week. If there are no more new types of > > restrictions, I will refine the previous PIP-242[0] to explain more details. > > > If we have other restrictions behind this discussion. We can draft a new > > PIP to add it directly. > > Thanks to Michael's opinion[1], we can expand the PIP-242 scopes to help > > pulsar have a good topic name restriction. > > > > Best, > > Mattison > > > > [0] https://github.com/apache/pulsar/issues/19239 > > [1] https://lists.apache.org/thread/dd1kxhodjvovtb8yyojkk209st4o0ft2 > >
