Thank you Yunze for double checking. I don't have time to test the release, so I am voting +0 (and not -1)
Enrico Il giorno gio 23 feb 2023 alle ore 12:57 Yunze Xu <y...@streamnative.io.invalid> ha scritto: > > Hi Enrico, > > I will test more operation systems and open a discussion soon. For > now, I just tested the TLS encryption and token authentication, and I > found this issue does not exist as expected for both Python and > Node.js clients. > - Windows: Only Python client works > - Ubuntu: Both work > - macOS: Not tested yet > > But the OAuth2 authentication case doesn't work. It's caused by > https://github.com/apache/pulsar/pull/16064 and fixed by > https://github.com/apache/pulsar-client-cpp/pull/190. > > When the protocol of the issuer URL is HTTPS: > - Before #16064, OAuth2 authentication works by skipping verifying the > peer, it's dangerous for security reasons > - After #16064 and before #190, there is no way to perform OAuth2 > authentication > - After #190, users can configure the `tls_trust_certs_file_path` to do that. > > So I think it should not be treated as a regression and should not > block this release. We can support automatically detecting the CA > certs for OAuth2 authentication later. > > The regression should be the case when the TLS encryption is enabled. > And as I've said at the beginning, I'm going to do more tests and open > a discussion. > > Thanks, > Yunze > > On Thu, Feb 23, 2023 at 6:06 PM Enrico Olivelli <eolive...@gmail.com> wrote: > > > > Does this version have the same problems about TLS CA Certs as the > > NodeJS client ? > > In that case I would cast a -1 > > > > Enrico > > > > Il giorno gio 23 feb 2023 alle ore 01:21 Matteo Merli > > <matteo.me...@gmail.com> ha scritto: > > > > > > +1 bindind > > > -- > > > Matteo Merli > > > <matteo.me...@gmail.com> > > > > > > > > > On Fri, Feb 17, 2023 at 3:27 AM Yunze Xu <y...@streamnative.io.invalid> > > > wrote: > > > > > > > This is the 3rd release candidate for Apache Pulsar Client Python, > > > > version 3.1.0. > > > > > > > > It fixes the following issues: > > > > https://github.com/apache/pulsar-client-python/milestone/2?closed=1 > > > > > > > > *** Please download, test and vote on this release. This vote will > > > > stay open for at least 72 hours *** > > > > > > > > Python wheels: > > > > > > > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-python-3.1.0-candidate-3/ > > > > > > > > The supported python versions are 3.7, 3.8, 3.9, 3.10 and 3.11. The > > > > supported platforms and architectures are: > > > > - Windows x86_64 (windows/) > > > > - glibc-based Linux x86_64 (linux-glibc-x86_64/) > > > > - glibc-based Linux arm64 (linux-glibc-arm64/) > > > > - musl-based Linux x86_64 (linux-musl-x86_64/) > > > > - musl-based Linux arm64 (linux-musl-arm64/) > > > > - macOS universal 2 (macos/) > > > > > > > > You can download the wheel (the `.whl` file) according to your own OS > > > > and Python version > > > > and install the wheel: > > > > - Windows: `py -m pip install *.whl --force-reinstall` > > > > - Linux or macOS: `python3 -m pip install *.whl --force-reinstall` > > > > > > > > The tag to be voted upon: v3.1.0-candidate-3 > > > > (9ed92ecee632c42b81a3198b8824d70d080af7f0) > > > > > > > > https://github.com/apache/pulsar-client-python/releases/tag/v3.1.0-candidate-3 > > > > > > > > Pulsar's KEYS file containing PGP keys you use to sign the release: > > > > https://dist.apache.org/repos/dist/release/pulsar/KEYS > > > > > > > > Please download the Python wheels and follow the README to test. > > > >
