+1 (non-binding) I verified:
+ source tarball has correct signature and checksum + LICENSE and NOTICE present + no binary in the source tarball + TLS tests works well with release candidate One comment here - it brings up several times (e.g. [1]) to use a single source of KEYS files. We don't need to duplicate it under the dev svn folder, but simply use https://downloads.apache.org/pulsar/KEYS, which is the same as https://dist.apache.org/repos/dist/release/pulsar/KEYS Best, tison. [1] https://lists.apache.org/thread/rs102bd6nj81ddq9fovqptnjr9jb866v Baodi Shi <ba...@apache.org> 于2023年4月12日周三 17:12写道： > Hi everyone, > > This is the first release candidate for Apache Pulsar Node.js client, > version 1.8.2. > > It fixes the following issues: > > https://github.com/apache/pulsar-client-node/pulls?q=is%3Apr+label%3Arelease%2Fv1.8.2+is%3Aclosed > > Please download the source files and review this release candidate: > - Download the source package, verify shasum and asc > - Follow the README.md <https://readme.md/> to build and run the Pulsar > Node.js client. > > The release candidate package has been published to the npm registry: > > https://www.npmjs.com/package/pulsar-client/v/1.8.2-rc.3 > > You can install it by `npm i pulsar-client@1.8.2-rc.3 > --pulsar_binary_host_mirror= > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/` > <https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/> > and verify the package. > > You can refer to this repository to verify tls related features: > > https://github.com/shibd/pulsar-client-tls-test > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Source files: > > https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-node/pulsar-client-node-1.8.2-rc.3/ > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/dev/pulsar/KEYS > > SHA-512 checksum: > > 98ff08092d3cd768a39499acac332cdec076a53b5521dad92c00810e8549165ede35eb3e2b1b6184265600e4e6a92356a2f142b1a1fa81d9c1461ac3c1e008f4 > ./apache-pulsar-client-node-1.8.2.tar.gz > > The tag to be voted upon: > v1.8.2-rc.3(c8e7c41 > < > https://github.com/apache/pulsar-client-node/commit/c8e7c41ee72c8a8f33cf1599ab87d0eabf45753c > > > ) > https://github.com/apache/pulsar-client-node/releases/tag/v1.8.2-rc. > <https://github.com/apache/pulsar-client-node/releases/tag/v1.8.2-rc.2>3 > > Please review and vote on the release candidate #1 for the version > 1.8.2, as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > > Thanks, > Baodi Shi >
