After several ping pongs over the PR, I'm changing my vote: +1 (non-binding)
Just please make sure to review all pending grammar suggestions. On Tue, Jun 6, 2023 at 10:53 PM Asaf Mesika <asaf.mes...@gmail.com> wrote: > I'm sorry for not getting back to you sooner: Weekend, work, etc. > > I vote -1 (non-binding), as I found something rather disturbing in the > design. > > Can we please go back to the discussion (in the PR)? > > Rui Fu - I see you voted +1 (binding) - what do you think about the > comments I've made? > > Thanks! > > > On Tue, Jun 6, 2023 at 8:07 AM Rui Fu <r...@apache.org> wrote: > >> +1 >> >> Best, >> >> Rui Fu >> On Jun 6, 2023 at 09:50 +0800, Pengcheng Jiang >> <pengcheng.ji...@streamnative.io.invalid>, wrote: >> > Hello, community: >> > >> > This thread is to start a vote for PIP-272: Add stateStorageConfig to >> > WorkerConfig. >> > >> > Discussion thread: >> > https://lists.apache.org/thread/pwfv7nj64frfnbw7jfydzx8my15b3lj6 >> > PR: https://github.com/apache/pulsar/pull/20455 >> > >> > Sincerely >> > Pengcheng Jiang >> >
