Close the vote with 4(+1 binding) 2(+1 non-binding) 0(-1) binding: Hang Yunze Mattison Penghui
non-binding Yubiao Asaf Regards Jiwei Guo (Tboy) On Mon, Jun 26, 2023 at 10:30 PM Hang Chen <chenh...@apache.org> wrote: > +1 (binding) > > Thanks, > Hang > > Yunze Xu <y...@streamnative.io.invalid> 于2023年6月26日周一 19:59写道： > > > > +1 (binding) > > > > Thanks, > > Yunze > > > > > > > > > > > On Jun 20, 2023, at 10:53, mattisonc...@gmail.com wrote: > > > > > > +1(binding) > > > > > > Best, > > > Mattison > > > On 20 Jun 2023 at 10:45 +0800, PengHui Li <peng...@apache.org>, wrote: > > >> +1 (binding) > > >> > > >> Thanks, > > >> Penghui > > >> > > >> On Tue, Jun 20, 2023 at 10:40 AM Yubiao Feng > > >> <yubiao.f...@streamnative.io.invalid> wrote: > > >> > > >>> Voting +1 (non-binding) > > >>> > > >>> Thanks > > >>> Yubiao Feng > > >>> > > >>> On Mon, Jun 19, 2023 at 5:21 PM Asaf Mesika <asaf.mes...@gmail.com> > wrote: > > >>> > > >>>>> Voting +1 (non-binding) > > >>>>> > > >>>>> On Fri, Jun 16, 2023 at 12:23 PM guo jiwei <techno...@apache.org> > wrote: > > >>>>> > > >>>>>>> @Asaf Thanks, I have addressed the comment. > > >>>>>>> > > >>>>>>> Regards > > >>>>>>> Jiwei Guo (Tboy) > > >>>>>>> > > >>>>>>> > > >>>>>>> On Fri, Jun 16, 2023 at 3:55 AM Asaf Mesika < > asaf.mes...@gmail.com> > > >>>>> wrote: > > >>>>>>> > > >>>>>>>>> -1 (non-binding) > > >>>>>>>>> > > >>>>>>>>> I'm perfectly ok with the idea; just please fix the document. > It > > >>> looks > > >>>>>>> too > > >>>>>>>>> messy. Even 1 paragraph changes can look neat and clean. > > >>>>>>>>> I left notes in the draft PR you opened for the pip. > > >>>>>>>>> > > >>>>>>>>> I'll change my non-binding vote once that's done. > > >>>>>>>>> > > >>>>>>>>> On Thu, Jun 15, 2023 at 11:07 AM guo jiwei < > techno...@apache.org> > > >>>>> wrote: > > >>>>>>>>> > > >>>>>>>>>>> Hi, community: > > >>>>>>>>>>> The metrics are all started with `pulsar_`, so that both > users > > >>>>> and > > >>>>>>>>>>> operators can quickly find the metrics of the entire system > through > > >>>>>>>>>>> this prefix. However, due to some other reasons, it was > found that > > >>>>>>>>>>> `topic_load_times` was missing the prefix, so want to get it > right. > > >>>>>>>>>>> In the master branch : > > >>>>>>>>>>> * `pulsar_topic_load_times`: Add this new metric which has > the > > >>>>>>> same > > >>>>>>>>>>> meaning as `topic_load_times` > > >>>>>>>>>>> * `topic_load_times`: Mark this metric as deprecated and > > >>> remove > > >>>>>>> it > > >>>>>>>>> in > > >>>>>>>>>>> the next version > > >>>>>>>>>>> > > >>>>>>>>>>> PIP: https://github.com/apache/pulsar/pull/20518 > > >>>>>>>>>>> > > >>>>>>>>>>> Regards > > >>>>>>>>>>> Jiwei Guo (Tboy) > > >>>>>>>>>>> > > >>>>>>>>> > > >>>>>>> > > >>>>> > > >>> > > >
