+1 (non-binding) Thanks, Ran Gao
On 2023/07/07 09:25:22 Joo Hyuk Kim wrote: > Hi community, > > This PIP has received a couple of approvals in github PR link [1] > So I thought it's time to vote. > > ## Motivation > > In the current Pulsar codebase, the logic to parse CLI arguments for > measurement units like time and bytes is > > scattered across various CLI classes. Each value read has its distinct > parsing implementation, leading to a lack of code > > reuse. > > > ## Goals > > > This PIP is to refactor the argument parsing logic to leverage the > `@Parameter.converter` > > functionality provided by JCommander [link 3]. This will isolate the > measurement-specific parsing logic and increase > > code > > reusability. > > > ### In Scope > > > - Refactor all `Cmd` classes to utilize the converter functionality of > JCommander. This will streamline the parsing > > logic and simplify the codebase. > > - Refer to bottom section "Concrete Example", before "Links" > > - Or on-going PR with small use case in > https://github.com/apache/pulsar/pull/20663 > > > ## links > > > [1] PR : https://github.com/apache/pulsar/pull/20691 > > > > Best regards, > > JooHyukKim (Vince) >
