Hi Heesung, I'm sorry for not getting back to you sooner. The motivation and the solution look good to me.
I just want to leave some comments to make the proposal clear for users and developers. ---------------------------------------------------------------------------------------------------- We should have a section to describe the values that will be added by this proposal. - Reduced the publish latency spike and e2e latency spike during the reconnecting - Mitigated bottleneck(lookup) of a large number of topics in a cluster Maybe more, I can only think about the above two values. ---------------------------------------------------------------------------------------------------- For the proto changes, the client side can also use the HTTP lookup service. We should also mention it in this proposal. Instead of adding four new fields to the CommandCloseProducer and CommandCloseConsumer, maybe adding a new message BrokerIdentifier, or others is better. ---------------------------------------------------------------------------------------------------- There are two points we need to clarify in the proposal. - If the client reconnects before the new owner takes ownership. If the producer closed after the new broker took ownership, would it be a potential consistency issue? - If the owner changed again before the client reconnection. How did Pulsar handle this case? As I understand, it's fine because the broker will check the ownership again when handling producer and consumer creation. If it can be explained in the proposal, it should be great for developers to understand it deeply. Regards, Penghui On Wed, Aug 2, 2023 at 1:18 AM Heesung Sohn <heesung.s...@streamnative.io.invalid> wrote: > Hi, > > It has been over three weeks since this discussion started, and I replied > to the questions in the PIP. > I will send out a vote email tomorrow if looking good. > > Thanks, > Heesung > > On Tue, Jul 25, 2023 at 1:12 PM Heesung Sohn <heesung.s...@streamnative.io > > > wrote: > > > Hi, > > > > I replied to the comments from Kai and Ran in the PIP. > > > > Please review the PIP by any chance. > > > > Thank you, > > Heesung > > > > On Thu, Jul 6, 2023 at 4:32 PM Heesung Sohn < > heesung.s...@streamnative.io> > > wrote: > > > >> Hi dev, > >> > >> I proposed this PIP, https://github.com/apache/pulsar/pull/20748, to > >> make unloaded clients directly and gracefully connect to new owner > brokers > >> without lookups. > >> > >> Please take a look and let me know what you think. > >> > >> Regards, > >> Heesung > >> > > >
