+1 (binding)

I checked

- Signature and checksums match
- Build the client from the source
- Run examples

Best,
tison.


Yunze Xu <x...@apache.org> 于2023年9月8日周五 01:15写道:

> +1 (binding)
>
> - Verified signature and checksums
> - Build from source with dotnet 7.0.400 on Windows 11
> - Run the example by adding the dotpulsar 3.0.0 dependency
>
> But I think there are some points to improve with the document. I'm
> new to the dotnet CLI though I have some experiences of C# a few years
> ago. I created the project via Visual Studio. However, when I tried to
> add the dependency via `dotnet add` command, I found it failed with a
> project template created by Visual Studio. Eventually I have to create
> and run a project via dotnet CLI:
>
> ```
> cd project-dir
> dotnet new console
> dotnet add package DotPulsar --version 3.0.0
> # Edit the Program.cs
> dotnet build
> dotnet run
> ```
>
> It would be helpful to provide more guide, even links to existings
> tutorial from MSDN.
>
> Thanks,
> Yunze
>
> On Tue, Sep 5, 2023 at 3:51 PM Zike Yang <z...@apache.org> wrote:
> >
> > +1 (non-binding)
> >
> > - Verified signature and checksums
> > - Install the nupkg file
> > - Build the client from the source
> > - Run examples
> >
> > But I find that the dotpulsar 3.0.0 has already been published to the
> > nuget.org: https://www.nuget.org/packages/DotPulsar/3.0.0
> >
> > BR,
> > Zike Yang
> >
> > On Sun, Sep 3, 2023 at 11:48 AM tison <wander4...@gmail.com> wrote:
> > >
> > > Hi everyone,
> > >
> > > This is the first release candidate for Apache DotPulsar, version
> 3.0.0.
> > >
> > > It fixes the following issues:
> > > https://github.com/apache/pulsar-dotpulsar/compare/2.11.1...3.0.0
> > >
> > > Please download the source files and review this release candidate:
> > > - Download the source package, verify shasum and asc
> > > - Follow the README.md to build and run the DotPulsar.
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Source files:
> > >
> https://dist.apache.org/repos/dist/dev/pulsar/pulsar-dotpulsar-3.0.0-candidate-1/
> > >
> > > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > > https://downloads.apache.org/pulsar/KEYS
> > >
> > > The tag to be voted upon:
> > > v3.0.0
> > > https://github.com/apache/pulsar-dotpulsar/releases/tag/3.0.0
> > >
> > > Please review and vote on the release candidate #1 for the version
> 3.0.0,
> > > as follows:
> > >
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > > Best,
> > > tison.
>

Reply via email to