+1 (binding) - Checked the signature - Build from source and run the tests
Regards, Penghui On Thu, Nov 9, 2023 at 5:15 PM Yunze Xu <x...@apache.org> wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source and run unit tests against the test standalone on > macOS Ventura 13.4 and Apple Clang 14.0.3 > > A tip for the failed LookupServiceTest.testMultiAddresses I mentioned > before, it's because this test has a too strict requirement that the > localhost should be mapped to 127.0.0.1, while on my macOS localhost > was mapped to IPv6 ::1 first. The test passed after I modified the > /etc/hosts file. > > Thanks, > Yunze > > On Thu, Nov 9, 2023 at 11:42 AM Yunze Xu <x...@apache.org> wrote: > > > > Hi Penghui, > > > > It's caused by the relative path and I explained it that issue. Here > > is an improvement for tests: > > https://github.com/apache/pulsar-client-cpp/pull/340. > > > > Thanks, > > Yunze >
